Tests: extract common blob store tests for reuse in plugins#14050
Tests: extract common blob store tests for reuse in plugins#14050imotov merged 1 commit intoelastic:masterfrom
Conversation
|
@tlrx that's what I had in mind. Could you take a look to see if it will help with GCS repo? |
There was a problem hiding this comment.
Maybe can we rename this class to FsBlobStoreTests ?
There was a problem hiding this comment.
Good catch. Renaming.
|
@imotov thanks for taking care of this, it looks great. I made few comments, mostly on the form and what we'd like to have in testing classes. |
|
@tlrx pushed some changes. when you have a moment, I would like to discuss your suggestion about the content of ESBlobStoreRepositoryIntegTestCase |
cb5a7d6 to
7378183
Compare
|
@tlrx I have rebased on the latest master and significantly simplify the common set of tests. Could you take another look and let me know if that makes more sense? |
There was a problem hiding this comment.
Could this be renamed to assertSuccessfulRestore?
|
@imotov I left some minor comments but nothing really important. I really like the latest changes, it's simpler and more meaningful so thanks a lot! |
7378183 to
1f07629
Compare
|
@tlrx great catch! Thanks! I have pushed the latest changes after your review. |
|
LGTM |
Adds unit tests for blob operations and integration tests for repository operations. These tests can be used by repository plugins to verify that repository operations were implemented as expected by BlobStoreRepository.
Extracts basic tests that can be shared with snapshot/restore plugins to test their basic functionality.