Add new IndexVersion to unblock rolling upgrades#139611
Closed
romseygeek wants to merge 2 commits intoelastic:patch/serverless-fixfrom
Closed
Add new IndexVersion to unblock rolling upgrades#139611romseygeek wants to merge 2 commits intoelastic:patch/serverless-fixfrom
romseygeek wants to merge 2 commits intoelastic:patch/serverless-fixfrom
Conversation
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
reviewed
Dec 16, 2025
| Property.ServerlessPublic | ||
| ); | ||
|
|
||
| private static final boolean STATEFUL_MODE_HACK = new FeatureFlag("doc_values_skipper").isEnabled(); |
Member
There was a problem hiding this comment.
What about doing this in IndexSettings's constructor (around line 1258):
if (scopedSettings.get(USE_DOC_VALUES_SKIPPER) == null && mode != IndexMode.TIME_SERIES) {
if (DiscoveryNode.isStateless(nodeSettings)
&& version.onOrAfter(IndexVersions.STATELESS_SKIPPERS_ENABLED_FOR_TSDB)
&& version.before(IndexVersions.STATELESS_SKIPPERS_DISABLED_BY_DEFAULT)) {
useDocValuesSkipper = true;
} else {
useDocValuesSkipper = false;
}
} else {
useDocValuesSkipper = scopedSettings.get(USE_DOC_VALUES_SKIPPER);
}
Then we don't need to STATEFUL_MODE_HACK constant?
martijnvg
reviewed
Dec 16, 2025
| public static final IndexVersion TIME_SERIES_USE_STORED_FIELDS_BLOOM_FILTER_FOR_ID = def(9_055_0_00, Version.LUCENE_10_3_2); | ||
| public static final IndexVersion AGG_METRIC_DOUBLE_REMOVE_POINTS = def(9_056_0_00, Version.LUCENE_10_3_2); | ||
| public static final IndexVersion STATELESS_SKIPPERS_ENABLED_FOR_TSDB = def(9_057_0_00, Version.LUCENE_10_3_2); | ||
| public static final IndexVersion STATELESS_SKIPPERS_DISABLED_BY_DEFAULT = def(9_058_0_00, Version.LUCENE_10_3_2); |
Member
There was a problem hiding this comment.
Also I think this needs to be a patch version? The 9_058_0_00 is also already taken in main?
Contributor
Author
|
Superseded by #139670 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.