Make TDigest ESQL type available outside of snapshot builds#139588
Make TDigest ESQL type available outside of snapshot builds#139588JonasKunz wants to merge 6 commits intoelastic:mainfrom
Conversation
…re-flag # Conflicts: # server/src/main/resources/transport/upper_bounds/9.3.csv
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
alex-spies
left a comment
There was a problem hiding this comment.
Heya, do we want to add TDIGEST to the AllSupportedFieldsTestCase?
Yes, definitely. For that to happen however we need to have lifted the feature flag for the ES field mapper for the This PR only adds the ES|QL type outside of snapshots, not the ES field type. |
Ah, I wondered if this is the case. In this case, this is not an indexable type and it's correct to exclude it from AllSupportedFieldsTestCase. That test is to make sure that new data types don't blow up |
| * @see DataType#isRepresentable(DataType) | ||
| */ | ||
| public static TypeResolution isRepresentableExceptCountersDenseVectorAggregateMetricDoubleAndExponentialHistogram( | ||
| public static TypeResolution isRepresentableExceptCountersDenseVectorAggregateMetricDoubleAndHistogram( |
There was a problem hiding this comment.
Please don't do this. Just inline this function, this is much harder to read.
|
Closed in favor of #139607 |
This PR makes the T-Digest ESQL type available outside of snapshot builds.
Note that the feature flag still remains, but now only corresponds to whether the
tdigestES field mapper is enabled or not, the ES|QL type is enabled unconditionally (it is notunderConstructionanymore).Unfortunately this means that we can't run the existing CSV-tests outside of snapshots, as they require the ES field type.
We should soon-ish add CSV tests which load
histogramfields, convert them totdigestand then run the corresponding queries. Those can then be run outside of snapshot builds.