ESQL: Enable AllSupportedFieldsTestCase in SNAPSHOT#139396
Merged
nik9000 merged 10 commits intoelastic:mainfrom Jan 22, 2026
Merged
ESQL: Enable AllSupportedFieldsTestCase in SNAPSHOT#139396nik9000 merged 10 commits intoelastic:mainfrom
nik9000 merged 10 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
15 tasks
…fieldsit-on-snapshot
…fieldsit-on-snapshot
Contributor
Author
|
Waiting on #133309, as the new DATE_RANGE type will require a test update if AllSupportedFieldsTestCase is enabled in SNAPSHOT. |
nik9000
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #137534
One step when adding a new data type is updating
AllSupportedFieldsTestCasewith new expectation for the data type, to ensure that queries likeFROM * | KEEP *orFROM * | ENRICH policykeep working when an existing data type gets support in ESQL.One annoying hurdle is that this test only ever runs for release builds. So one can entirely miss the test until after releasing the new type (even though it's mentioned in the docs for adding a new type) and ends up with a broken build, remaining unaware of the bwc problems this test guards against until the very last minute.
Wouldn't it be nice if we could just run it in release mode and already update the test expectations for SNAPSHOT builds? So we can see what the behavior of queries will look like with the new type, without actually having to release the type for this?
As #137432 enabled version-aware planning of data types in SNAPSHOT builds, we can do just that, making this test suite less weird and hopefully easier to work with.