Exclude search tests from common CCS test suite#139238
Merged
davidkyle merged 1 commit intoelastic:mainfrom Dec 12, 2025
Merged
Exclude search tests from common CCS test suite#139238davidkyle merged 1 commit intoelastic:mainfrom
davidkyle merged 1 commit intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
benwtrent
reviewed
Dec 9, 2025
| // Search tests are not executed in the common suite. | ||
| case CcsCommonYamlTestSuiteIT cssCommon -> isSearchApi(apiName) == false; | ||
| case RcsCcsCommonYamlTestSuiteIT rssCommon -> isSearchApi(apiName) == false; | ||
| default -> throw new IllegalArgumentException("unexpected test suite [" + testSuite.getClass().getSimpleName() + "]"); |
Member
There was a problem hiding this comment.
I have a feeling that throwing will be a bad idea. There are way more test suites than those two...I think defaulting to true should be ok right? Why not?
Member
Author
There was a problem hiding this comment.
Throwing would be caught early in CI and fixed. Defaulting to true means that we are unaware of bugs or other issues, this fix being a case in point. Remember this code only applies to the ccs-common-rest module
benwtrent
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on from #139107 which did not actually include the logic to stop the search tests being run in the common test suite.
I tried adding a unit test for this logic but Gradle complained. As noted in #139107 this should been seen as a long term solution.