Optimize sort settings default providers#138711
Merged
jordan-powers merged 4 commits intoelastic:mainfrom Dec 4, 2025
Merged
Conversation
Contributor
Author
|
Benchmark results running the elastic/logs many-shards-quantitative benchmark in esbench. Baseline ref: 22a7491 Results: |
…ngs-default-providers-2
Contributor
Author
|
Ok, I ran another benchmark with the optimizations from this PR cherry-picked onto the first commit that introduced the regression. This eliminates any slowdowns due to other changes since the original regression was introduced. Baseline ref: 22a7491 |
Contributor
Author
SummaryThis PR fixes a regression in the initial-indices step of the elastic/logs many-shards-quantitative benchmark.
Since the performance returned to the baseline throughput (within noise) when the fix was cherry-picked on top of the original regression, I believe this fix completely resolves the original regression. |
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
Dec 4, 2025
Member
martijnvg
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks for presenting the results in such a clear way.
However, there still remains some slowdown due to other changes since that initial regression that likely should be investigated separately.
Did flame graphs suggest what the other slowdown(s) could be?
Contributor
Author
I'm not certain, but possibly something security related? I'll post more details on the original investigation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes the default providers for the sort settings
index.sort.field,index.sort.order,index.sort.mode, andindex.sort.missingto fix a performance regression in the many-shards-quantitative benchmark associated with the introduction of these default providers in #135886.