server/src/main/java/org/elasticsearch/monitor/os/OsStats.java (1)

217-222: ⚠️ Potential issue | 🟠 Major

Missing clamping in Swap(StreamInput in) when assertions disabled.

The Swap(long, long) constructor now clamps negative values to 0 when assertions are disabled (lines 205-212), but Swap(StreamInput in) only has assertions without the protective clamping. Compare with Mem(StreamInput in) (lines 296-319) which includes both assertions AND clamping.

If a negative swap value arrives via deserialization with assertions disabled, the runtime IllegalArgumentException can still occur.

Proposed fix

     public Swap(StreamInput in) throws IOException {
-        this.total = in.readLong();
+        long total = in.readLong();
         assert this.total >= 0 : "expected total swap to be positive, got: " + total;
-        this.free = in.readLong();
+        if (total < 0) {
+            logger.error("negative total swap [{}] deserialized in swap stats", total);
+            total = 0;
+        }
+        this.total = total;
+        long free = in.readLong();
         assert this.free >= 0 : "expected free swap to be positive, got: " + free;
+        if (free < 0) {
+            logger.error("negative free swap [{}] deserialized in swap stats", free);
+            free = 0;
+        }
+        this.free = free;
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@server/src/main/java/org/elasticsearch/monitor/os/OsStats.java` around lines
217 - 222, The Swap(StreamInput in) constructor only asserts non-negative values
but does not clamp them, so when assertions are disabled a negative deserialized
value can cause later IllegalArgumentException; update Swap(StreamInput in) to
mirror Mem(StreamInput in) by reading total and free, assert they are >= 0, then
clamp any negative total/free to 0 (like the Swap(long, long) constructor does)
so deserialized negative swap values are safely normalized.