ESQL - Add field function pushing node reduce plan tests#138529
Merged
carlosdelest merged 24 commits intoelastic:mainfrom Dec 12, 2025
Merged
Conversation
added 2 commits
November 24, 2025 11:57
added 7 commits
November 24, 2025 19:56
carlosdelest
commented
Nov 26, 2025
|
|
||
| @ClassRule | ||
| public static ElasticsearchCluster cluster = Clusters.testCluster(spec -> spec.plugin("inference-service-test")); | ||
| public static ElasticsearchCluster cluster = Clusters.testCluster(); |
Member
Author
There was a problem hiding this comment.
No inference needed, simplifying
| Map.of("data", List.of(expectedLoaders)), assertDataNodeSig); | ||
| } | ||
|
|
||
| private void test( |
Member
Author
There was a problem hiding this comment.
Reorganized the tests so we can check directly:
- The expected columns
- The expected field loaders per driver - we can check the field loaders for data and node_reduce drivers independently.
16 tasks
added 6 commits
November 26, 2025 18:32
…on-loaders-pushdown-testing
…aders-pushdown-testing' into non-issue/esql-function-loaders-pushdown-testing
…on-loaders-pushdown-testing
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
nik9000
approved these changes
Dec 9, 2025
| // Pushed down function | ||
| matchesMap().entry("test:column_at_a_time:Utf8CodePointsFromOrds.Singleton", 1), | ||
| // Field | ||
| matchesMap().entry("test:row_stride:BytesRefsFromOrds.Singleton", 1) |
Member
There was a problem hiding this comment.
I'm not entirely sure we should push here - but that's complex! Either way, we push now and testing that is good.
…on-loaders-pushdown-testing # Conflicts: # x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/LocalLogicalPlanOptimizerTests.java
…aders-pushdown-testing' into non-issue/esql-function-loaders-pushdown-testing
Member
Author
|
@elasticmachine run Elasticsearch Serverless Checks |
…on-loaders-pushdown-testing # Conflicts: # x-pack/plugin/esql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/PushExpressionToLoadIT.java
…aders-pushdown-testing' into non-issue/esql-function-loaders-pushdown-testing
…on-loaders-pushdown-testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #137679
Adds tests around pushing down functions on node_reduce tests.