ESQL: Implement coalesce for exponential histograms#137897
ESQL: Implement coalesce for exponential histograms#137897JonasKunz merged 9 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
x-pack/plugin/esql/build.gradle
Outdated
| "src/main/generated-src/generated/**/*.java" | ||
| "src/main/generated-src/generated/**/*.java", | ||
| // This file contains too long lines for spotless, but we don't want to mess with the template unnecessarily | ||
| "src/main/generated-src/org/elasticsearch/xpack/esql/expression/function/scalar/nulls/CoalesceExponentialHistogramEvaluator.java" |
There was a problem hiding this comment.
The alternative to this excldue would be to adjust the line breaks in the template - let me know what you prefer
There was a problem hiding this comment.
@nik9000 suggested to try to see if we can somehow selectively disable the check only for those lines. I'll give that a try and see if I can make it work
There was a problem hiding this comment.
It seems like the spotless config only allows for a single comment pair to disable spotless selectively, which is already taken by // begin generated imports. We'd have to replace that with something generic like // spotless:off if we want to go that route.
I know inserted comments to force line breaks in the template instead, please let me know if that is fine for you.
nik9000
left a comment
There was a problem hiding this comment.
I had just scanned the generated code before, but now I've checked it all. The whole thing looks good to me.
Adds coalesce support for exponential histograms, part of #137549.