Closed
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
luigidellaquila
approved these changes
Oct 17, 2025
alex-spies
reviewed
Oct 17, 2025
Contributor
alex-spies
left a comment
There was a problem hiding this comment.
Do we plan to use the new mutability of PreAnalysisResult in resolveIndicesAndAnalyze? That's where PreAnalysisResult is being the most tedious, as we pass it through the listener chain rather than capturing it in the lambdas and mutating it.
Without that, it doesn't seem like we actuallly simplify the code.
When we merge this, maybe let's also backport to 9.2 - Nik still has some code in flight that will be backported and probably touches the EsqlSession.
Contributor
Author
|
Outdated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces semi-immutable record with inner static class. This way we could avoid copying it every time we add resolved data saving some object allocation and code verbosity.