Fix Flaky Semantic Search CCS Integration Tests#135629
Merged
Mikep86 merged 5 commits intoelastic:mainfrom Sep 29, 2025
Merged
Conversation
Collaborator
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
kderusso
approved these changes
Sep 29, 2025
...lusterTest/java/org/elasticsearch/search/ccs/AbstractSemanticCrossClusterSearchTestCase.java
Outdated
Show resolved
Hide resolved
| .cluster() | ||
| .prepareHealth(TEST_REQUEST_TIMEOUT, indexName) | ||
| .setWaitForYellowStatus() | ||
| .setWaitForGreenStatus() |
Member
There was a problem hiding this comment.
I think it should never be yellow if there are 0 replicas, only green, so maybe you could keep the wait for yellow status? But I'm OK leaving this as is as long as we don't think there's a testing hole
Contributor
Author
There was a problem hiding this comment.
Good point, but if it should never be yellow then this check should be fine and IMO at the very least it clarifies the state we want the clusters to be in before starting tests.
| RemoteInfoRequest request = new RemoteInfoRequest(); | ||
| boolean connected; | ||
| int attempts = 0; | ||
| int delayInSeconds = 0; |
Contributor
There was a problem hiding this comment.
I think this can be made simpler reusing assertBusy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flaky semantic search CCS integration tests by making the following changes:
Fixes #135559 and #135573