[ES|QL] Round stddev tests more aggressively#135217
Conversation
fa3a3ee to
45b326e
Compare
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
c863ca0 to
9f4ffe9
Compare
94923e9 to
1ff1e85
Compare
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
astefan
left a comment
There was a problem hiding this comment.
LGTM from my side. Thank you for the quick reaction to these CI failures.
But, I trust your judgement that the aggressive rounding we are adopting is not detrimental to the correctness of the STD_DEV function results and that doing so will not hide bugs regarding the results accuracy of this function.
|
Standard deviation appears to be reported on the level of about 3 significant figures at most typically, and while some of these tests now only have 5, there's at least one test for each supported type that have 7+, which I think is more than a safe amount |
Adjust the rounding for std_dev CSV tests so they are less sensitive to the whims of fate
Hopefully:
Closes #135100
Closes #135101
Closes #135102
Closes #135103