ES|QL - Dense vector tyoe - Enable bit element type#134326
Merged
afoucret merged 4 commits intoelastic:mainfrom Sep 10, 2025
Merged
ES|QL - Dense vector tyoe - Enable bit element type#134326afoucret merged 4 commits intoelastic:mainfrom
afoucret merged 4 commits intoelastic:mainfrom
Conversation
This commit introduces support for the `bit` element type in dense vector fields.
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
carlosdelest
reviewed
Sep 9, 2025
Member
carlosdelest
left a comment
There was a problem hiding this comment.
Changes LGTM 💯
There are some tests in AnalyzerTests that could be updated with the new bit element type (search for float_vector and byte_vector). Can you please take a look?
server/src/main/java/org/elasticsearch/index/mapper/BlockDocValuesReader.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@carlosdelest I added some test cases in AnalyzerTests |
7 tasks
carlosdelest
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces support for the
bitelement type in dense vector fields.Related issue #125783