Split NestedQueryParser into toQuery and formXContent#13424
Merged
s1monw merged 1 commit intoelastic:feature/query-refactoringfrom Sep 10, 2015
Merged
Split NestedQueryParser into toQuery and formXContent#13424s1monw merged 1 commit intoelastic:feature/query-refactoringfrom
s1monw merged 1 commit intoelastic:feature/query-refactoringfrom
Conversation
Contributor
There was a problem hiding this comment.
no null checks here for path and query?
Contributor
Author
There was a problem hiding this comment.
oooh good catch how did I miss that? :)
Contributor
|
left a few comments, looks good though |
4306091 to
adad160
Compare
Contributor
Author
|
@javanna I addressed all comments |
Contributor
|
LGTM |
This commit splits NestedQueryParser into toQuery and fromXContent. Relates to elastic#10217
adad160 to
8d2a2f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit splits NestedQueryParser into toQuery and fromXContent.
Relates to #10217