Force Connect Test: Fix flaky test caused by unreliable remote cluster stalling#132641
Merged
pawankartik-elastic merged 3 commits intoelastic:mainfrom Aug 11, 2025
Merged
Conversation
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
drempapis
reviewed
Aug 11, 2025
| ); | ||
| for (String remoteNodeName : cluster(LINKED_CLUSTER_1).getNodeNames()) { | ||
| TransportService remoteTs = cluster(LINKED_CLUSTER_1).getInstance(TransportService.class, remoteNodeName); | ||
| localMts.addConnectBehavior(remoteTs, ((transport, discoveryNode, profile, listener) -> { |
Contributor
There was a problem hiding this comment.
If I understand well, the updated code blocks all remote targets per local node, making the timeout behavior-assertions reliable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to reproduce the flaky-ness and the changes in this PR seem to have fixed the flaky-ness.
Without these changes = failures seen when running the tests for multiple iterations.
With these changes = no failures when running the tests for multiple iterations (100+ iterations).
Hopefully, fixes #131656 and #132179.