[ML] Inference services - remove unused init method#131759
Merged
davidkyle merged 6 commits intoelastic:mainfrom Aug 27, 2025
Merged
[ML] Inference services - remove unused init method#131759davidkyle merged 6 commits intoelastic:mainfrom
davidkyle merged 6 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
| protected static final Set<TaskType> COMPLETION_ONLY = EnumSet.of(TaskType.COMPLETION); | ||
| private final Sender sender; | ||
| private final ServiceComponents serviceComponents; | ||
| private final ClusterService clusterService; |
Contributor
There was a problem hiding this comment.
I think this PR: https://github.com/elastic/elasticsearch/pull/131551/files#diff-7ac70d182c5505ff84ebb34581462f562d52780c090b60ce80e665476819d4ccR76
Is planning on using the ClusterService.
Member
Author
There was a problem hiding this comment.
I left a comment on the PR
jonathan-buttner
approved these changes
Aug 26, 2025
Member
Author
|
run Elasticsearch Serverless Checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
init()method is not called by anyone