disable ReplaceStringCasingWithInsensitiveRegexMatch rule in 8.19#131387
Merged
julian-elastic merged 6 commits intoelastic:8.19from Jul 17, 2025
Merged
disable ReplaceStringCasingWithInsensitiveRegexMatch rule in 8.19#131387julian-elastic merged 6 commits intoelastic:8.19from
julian-elastic merged 6 commits intoelastic:8.19from
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @julian-elastic, I've created a changelog YAML for you. |
8ab7107 to
ee65f6d
Compare
bpintea
approved these changes
Jul 17, 2025
x-pack/plugin/esql/qa/testFixtures/src/main/resources/where-like.csv-spec
Show resolved
Hide resolved
...gin/esql/src/main/java/org/elasticsearch/xpack/esql/optimizer/LocalLogicalPlanOptimizer.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Hi @julian-elastic, I've created a changelog YAML for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables the ReplaceStringCasingWithInsensitiveRegexMatch rule for 8.19, originally added with #128919
This is due to Lucene missing support for Unicode CASE_INSENSITIVE automation. If we allow the pushdown, we end up with wrong data in the vase majority of the cases when Unicode characters are involved.
#131386 is logged for a complete fix and to reenable the change