Patch for Lucene bug 14857#130254
Merged
elasticsearchmachine merged 11 commits intoelastic:8.19from Jul 1, 2025
Merged
Conversation
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
|
Hi @benwtrent, I've created a changelog YAML for you. |
john-wagster
approved these changes
Jun 28, 2025
Contributor
john-wagster
left a comment
There was a problem hiding this comment.
might be worth considering porting the testAdvanceAdverseShallow test here for now or creating some similar test. And seems like Adrien's comment on the NO_MORE_DOCS check from the Lucene PR is applicable here as well.
otherwise lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, advanceShallow for knn queries can flip back from hitting NO_MORE_DOCS to a valid doc ID again. This can cause search higher level queries to flip back and forth breaking assumptions and causing a CPU core to be locked up in-definitely (until server reboot).
Applies the fix provided here, but requires gathering score docs again: apache/lucene#14858
closes: #130239