Fix security index creation race condition#128825
Merged
jfreden merged 3 commits intoelastic:mainfrom Jun 4, 2025
Merged
Conversation
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
slobodanadamovic
approved these changes
Jun 3, 2025
Contributor
slobodanadamovic
left a comment
There was a problem hiding this comment.
LGTM Thanks for fixing this 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #127694, #122863
The error occurs when trying to authenticate the activate profile request:
Before the test, the creation of the .security index is skipped:
And before that we see:
Even earlier we see:
This is triggered by
prepareIndexIfNeededThenExecute.What I think is happening is that the index is created but not available and therefore it fails. If we check if exists and also wait for it to become available this might not happen.