Clear per-shard failure earlier in AbstractSearchAsyncAction.onShardResult#126933
Merged
original-brownbear merged 1 commit intoelastic:mainfrom Apr 18, 2025
original-brownbear:clear-shard-failure-earlier
Merged
Clear per-shard failure earlier in AbstractSearchAsyncAction.onShardResult#126933original-brownbear merged 1 commit intoelastic:mainfrom original-brownbear:clear-shard-failure-earlier
original-brownbear merged 1 commit intoelastic:mainfrom
original-brownbear:clear-shard-failure-earlier
Conversation
…esult We can clean the failure before we potentially go async for a partial merge here to save some heap and needless reference chains to the per-shard result.
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
benchaplin
approved these changes
Apr 18, 2025
Contributor
benchaplin
left a comment
There was a problem hiding this comment.
Approved.
I understand how this removes "needless reference chains" but I don't see how those references might be "circular(ish)" in a heap dump.
Contributor
Author
|
Thanks Ben! The referfence comment came from the fact that we were referencing the result from the |
This was referenced Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can clean the failure before we potentially go async for a partial merge here to save some heap and needless reference chains to the per-shard result.
Mainly interesting because it makes heap dumps easier to understand by avoiding the circular(ish) reference chains to the result. Also just another small improvement saving a little allocation.