Skip to content

[8.x] ESQL: Catch parsing exception (#124958)#124972

Closed
costin wants to merge 1 commit intoelastic:8.xfrom
costin:backport/8.x/pr-124958
Closed

[8.x] ESQL: Catch parsing exception (#124958)#124972
costin wants to merge 1 commit intoelastic:8.xfrom
costin:backport/8.x/pr-124958

Conversation

@costin
Copy link
Copy Markdown
Member

@costin costin commented Mar 16, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

When an invalid popMode occurs (due to an invalid query), ANTLR throws
 an out-of-channel exception, bypassing the existing checks.
This PR extends the checks and properly reports the error back to the
 user

Fix elastic#119025

(cherry picked from commit dc15462)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/EsqlParser.java
@costin costin added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 16, 2025
@costin
Copy link
Copy Markdown
Member Author

costin commented Mar 17, 2025

Incorrect PR

@costin costin closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v8.19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants