Skip to content

Run XPack usage actions on local node#122933

Merged
nielsbauman merged 3 commits intoelastic:mainfrom
nielsbauman:local-xpack-usage
Mar 3, 2025
Merged

Run XPack usage actions on local node#122933
nielsbauman merged 3 commits intoelastic:mainfrom
nielsbauman:local-xpack-usage

Conversation

@nielsbauman
Copy link
Copy Markdown
Contributor

These actions solely need the cluster state, they can run on any node.

Relates #101805

These actions solely need the cluster state, they can run on any node.

Relates elastic#101805
@nielsbauman nielsbauman added >enhancement :Core/Infra/Stats Statistics tracking and retrieval APIs Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v9.1.0 labels Feb 19, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Hi @nielsbauman, I've created a changelog YAML for you.

@nielsbauman
Copy link
Copy Markdown
Contributor Author

I'm not actually sure if we (Data Management) own this feature. I'm happy to change the label if another team owns it.

Copy link
Copy Markdown
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only thing that I'm a little uneasy about is that one of these many many transport actions (I did not audit them all) is injecting some service that only works correctly on the master node. I assume that if it did, then we'd hopefully find it in tests though.

@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Mar 3, 2025
@nielsbauman
Copy link
Copy Markdown
Contributor Author

LGTM, the only thing that I'm a little uneasy about is that one of these many many transport actions (I did not audit them all) is injecting some service that only works correctly on the master node. I assume that if it did, then we'd hopefully find it in tests though.

I did go over all transport actions and I did not identify any actions that depend on some service that only works correctly on the master node. I might have missed something of course, but I also assume that tests would help us out in this case (and I've run a few CIs on this branch already).

@nielsbauman nielsbauman merged commit afff39e into elastic:main Mar 3, 2025
18 checks passed
@nielsbauman nielsbauman deleted the local-xpack-usage branch March 3, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Stats Statistics tracking and retrieval APIs >enhancement serverless-linked Added by automation, don't add manually Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants