Fix transport serialization of EnrichStatsAction.Request#121735
Merged
nielsbauman merged 4 commits intoelastic:mainfrom Feb 6, 2025
Merged
Fix transport serialization of EnrichStatsAction.Request#121735nielsbauman merged 4 commits intoelastic:mainfrom
EnrichStatsAction.Request#121735nielsbauman merged 4 commits intoelastic:mainfrom
Conversation
In elastic#121256, we changed the superclass of the request to `LocalClusterStateRequest` to make the action run on the local node instead of the master node. Most of the actions that have been updated thusfar to run on the local node used to extend `MasterNodeReadRequest` and thus serialized a `local` field. This request class, however, extended `MasterNodeRequest`, meaning that it didn't serialize that field.
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Contributor
Author
|
I'm having trouble running the failing test to prove that my changes actually fixed the issue. While I try to get the test to run locally, this PR can already be reviewed. Also, putting |
dakrone
approved these changes
Feb 5, 2025
Member
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I left one question about the javadoc
server/src/main/java/org/elasticsearch/action/support/local/LocalClusterStateRequest.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #121256, we changed the superclass of the request to
LocalClusterStateRequestto make the action run on the local node instead of the master node. Most of the actions that have been updated thusfar to run on the local node used to extendMasterNodeReadRequestand thus serialized alocalfield. This request class, however, extendedMasterNodeRequest, meaning that it didn't serialize that field.Fixes #121642