Skip to content

[8.x] ESQL: Implement a MetricsAware interface (#121074)#121164

Merged
elasticsearchmachine merged 1 commit intoelastic:8.xfrom
bpintea:backport/8.x/pr-121074
Jan 29, 2025
Merged

[8.x] ESQL: Implement a MetricsAware interface (#121074)#121164
elasticsearchmachine merged 1 commit intoelastic:8.xfrom
bpintea:backport/8.x/pr-121074

Conversation

@bpintea
Copy link
Copy Markdown
Contributor

@bpintea bpintea commented Jan 29, 2025

Backports the following commits to 8.x:

* ESQL: Implement a MetricsAware interface (elastic#120527)

This implements an interface that export the names of the plan nodes and
functions that need to be counted in the metrics.

Also, the metrics are now counted from within the parser. This should
allow correct accounting for the cases where some nodes can appear both
standalone or part other nodes' children (like Aggregate being a child
of INLINESTATS, so no STATS counting should occur).

The functions counting now also validates that behind a name there is
actually a function registered.

Closes elastic#115992.

(cherry picked from commit a4482d4)

* Drop the HashSet gating when counting commands

The telemetry accounting is no longer done in just one place in the parser,
but split, so that no HashSet is required to discard duplicate accounting of
the same node. This lowers the memory requirements.
@bpintea bpintea added :Analytics/ES|QL AKA ESQL >enhancement auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Jan 29, 2025
@elasticsearchmachine elasticsearchmachine merged commit 314ebd0 into elastic:8.x Jan 29, 2025
@bpintea bpintea deleted the backport/8.x/pr-121074 branch January 29, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants