[TEST] Handle ignore_above in KeywordFieldBlockLoaderTests#119800
Merged
elasticsearchmachine merged 2 commits intoelastic:mainfrom Jan 8, 2025
Merged
[TEST] Handle ignore_above in KeywordFieldBlockLoaderTests#119800elasticsearchmachine merged 2 commits intoelastic:mainfrom
elasticsearchmachine merged 2 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
lkts
commented
Jan 8, 2025
|
|
||
| if (ESTestCase.randomDouble() <= 0.2) { | ||
| injected.put("ignore_above", ESTestCase.randomIntBetween(1, 10000)); | ||
| injected.put("ignore_above", ESTestCase.randomIntBetween(1, 100)); |
Contributor
Author
There was a problem hiding this comment.
We don't ever generate such long strings so large values act as a "skip" in a lot of tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #119415 with #119416 landing previously.