ESQL: fix COUNT filter pushdown (#117503)#117648
Merged
elasticsearchmachine merged 4 commits intoelastic:8.xfrom Nov 28, 2024
Merged
ESQL: fix COUNT filter pushdown (#117503)#117648elasticsearchmachine merged 4 commits intoelastic:8.xfrom
elasticsearchmachine merged 4 commits intoelastic:8.xfrom
Conversation
If `COUNT` agg has a filter applied, this must also be push down to source. This currently does not happen, but this issue is masked currently by two factors: * a logical optimisation, `ExtractAggregateCommonFilter` that extracts the filter out of the STATS entirely (and pushes it to source then from a `WHERE`); * the phisical plan optimisation implementing the push down, `PushStatsToSource`, currently only applies if there's just one agg function to push down. However, this fix needs to be applied since: * it's still present in versions prior to `ExtractAggregateCommonFilter` introduction; * the defect might resurface when the restriction in `PushStatsToSource` is lifted. Fixes elastic#115522. (cherry picked from commit 560e0c5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
COUNTagg has a filter applied, this must also be push down to source. This currently does not happen, but this issue is masked currently by two factors:ExtractAggregateCommonFilterthat extracts the filter out of the STATS entirely (and pushes it to source then from aWHERE);PushStatsToSource, currently only applies if there's just one agg function to push down.However, this fix needs to be applied since:
ExtractAggregateCommonFilterintroduction;PushStatsToSourceis lifted.Fixes #115522.
(cherry picked from commit 560e0c5)