Empty mappings equals empty properties#114624
Open
piergm wants to merge 45 commits intoelastic:mainfrom
Open
Conversation
…tly-in-field_caps
…tly-in-field_caps
Collaborator
|
Hi @piergm, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Contributor
|
Ping @piergm |
…iergm/elasticsearch into empty_mappings_equals_empty_properties
…iergm/elasticsearch into empty_mappings_equals_empty_properties
…iergm/elasticsearch into empty_mappings_equals_empty_properties
Member
Author
|
Due to "MetadataMappingServiceTests.testMappingVersionUnchanged" failing this is taking more time than expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mappings defaults to
{}aka EMPTY_MAPPING, both ifmappings: {}and ifmappings: {properties: {}}is passed in the request body to match the behaviour when passing empty mapping on index create.Prior to this change only
mappings: {properties: {}}was instead wrapped with with_doc, now all the above.With this
{}=={mappings: {}}=={mappings: {properties: {}}}fixes #107031