Skip to content

[8.15] Fix dim validation for bit element_type (#114533)#114610

Merged
elasticsearchmachine merged 1 commit intoelastic:8.15from
benwtrent:backport/8.15/pr-114533
Oct 11, 2024
Merged

[8.15] Fix dim validation for bit element_type (#114533)#114610
elasticsearchmachine merged 1 commit intoelastic:8.15from
benwtrent:backport/8.15/pr-114533

Conversation

@benwtrent
Copy link
Copy Markdown
Member

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

A silly bug has reared its ugly head. Apparently, our dimension
validations are predicated on JSON parsing order, that is not good.

So, this commit adjusts the dim validations so that it is an actual
validation, instead of something that occurs during parsing.

Additionally, I found that our custom formats were not overriding
`getMaxDimensions` correctly. Typically, and in production, this isn't
that big of a deal, but I have found it useful to do this for other
testing purposes (so that we don't have to rely on the perfield codec
for more direct and advanced testing).

(cherry picked from commit 7942f3e)
@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 11, 2024
@elasticsearchmachine elasticsearchmachine merged commit f964e5f into elastic:8.15 Oct 11, 2024
@benwtrent benwtrent deleted the backport/8.15/pr-114533 branch October 11, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v8.15.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants