Skip to content

[8.x] Fix dim validation for bit element_type (#114533)#114609

Merged
elasticsearchmachine merged 2 commits intoelastic:8.xfrom
benwtrent:backport/8.x/pr-114533
Oct 11, 2024
Merged

[8.x] Fix dim validation for bit element_type (#114533)#114609
elasticsearchmachine merged 2 commits intoelastic:8.xfrom
benwtrent:backport/8.x/pr-114533

Conversation

@benwtrent
Copy link
Copy Markdown
Member

Backports the following commits to 8.x:

A silly bug has reared its ugly head. Apparently, our dimension
validations are predicated on JSON parsing order, that is not good. 

So, this commit adjusts the dim validations so that it is an actual
validation, instead of something that occurs during parsing.

Additionally, I found that our custom formats were not overriding
`getMaxDimensions` correctly. Typically, and in production, this isn't
that big of a deal, but I have found it useful to do this for other
testing purposes (so that we don't have to rely on the perfield codec
for more direct and advanced testing).
@benwtrent benwtrent added :Search Relevance/Vectors Vector search >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Oct 11, 2024
@benwtrent
Copy link
Copy Markdown
Member Author

run elasticsearch-ci/part-1

@benwtrent
Copy link
Copy Markdown
Member Author

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit 1ad4ae1 into elastic:8.x Oct 11, 2024
@benwtrent benwtrent deleted the backport/8.x/pr-114533 branch October 11, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants