Skip to content

[8.x] [ESQL] Support datetime data type in Least and Greatest functions (#113961)#114130

Merged
elasticsearchmachine merged 1 commit intoelastic:8.xfrom
not-napoleon:backport/8.x/pr-113961
Oct 4, 2024
Merged

[8.x] [ESQL] Support datetime data type in Least and Greatest functions (#113961)#114130
elasticsearchmachine merged 1 commit intoelastic:8.xfrom
not-napoleon:backport/8.x/pr-113961

Conversation

@not-napoleon
Copy link
Copy Markdown
Member

Backports the following commits to 8.x:

…astic#113961)

While working on Date Nanos, I noticed that Least and Greatest didn't have support for datetime. This PR corrects that and adds tests for it.

It seems to me that resolveType() is doing the wrong thing for these functions, as it accepts types that then do not have evaluator mappings, but refactoring that seems out of scope right now.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@not-napoleon not-napoleon added :Analytics/ES|QL AKA ESQL >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Oct 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 4, 2024

Documentation preview:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants