Clean up timeouts in reserved cluster state handlers#112820
Merged
elasticsearchmachine merged 2 commits intoelastic:mainfrom Sep 12, 2024
Merged
Conversation
In elastic#109828 we introduced a `DUMMY_TIMEOUT` constant for these handlers in which timeouts are ignored, but we have not been very consistent with its usage and it has an overly-generic name making it harder for readers to understand its meaning. This commit renames the constant to clarify why it's being used, and fixes up several spots where we should have been using it already.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
approved these changes
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #109828 we introduced a
DUMMY_TIMEOUTconstant for these handlersin which timeouts are ignored, but we have not been very consistent with
its usage and it has an overly-generic name making it harder for readers
to understand its meaning.
This commit renames the constant to clarify why it's being used, and
fixes up several spots where we should have been using it already.