Check if the index can be opened and is not corrupted on state listing#11269
Merged
s1monw merged 1 commit intoelastic:masterfrom May 21, 2015
Merged
Check if the index can be opened and is not corrupted on state listing#11269s1monw merged 1 commit intoelastic:masterfrom
s1monw merged 1 commit intoelastic:masterfrom
Conversation
Contributor
Author
|
@kimchy can you look |
026c98c to
b4987d3
Compare
Contributor
There was a problem hiding this comment.
cat we add a trace log here with the exception? Thinking it might be helpful to be able to know why...
Contributor
|
LGTM (left two minor comments). |
Contributor
Author
|
pushed a new commit - I will push that to master soon |
We fetch the state version to find the right shard to be started as the primary. This can return a valid shard state even if the shard is corrupted and can't even be opened. This commit adds best effort detection for this scenario and returns an invalid version for the shard if it's corrupted Closes elastic#11226
3d911f0 to
4cb21d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fetch the state version to find the right shard to be started as
the primary. This can return a valid shard state even if the shard is
corrupted and can't even be opened. This commit adds best effort detection
for this scenario and returns an invalid version for the shard if it's corrupted
Closes #11226