Skip to content

[8.15] ESQL: Fix for overzealous validation in case of invalid mapped fields (#111475)#111735

Merged
elasticsearchmachine merged 1 commit intoelastic:8.15from
alex-spies:backport/8.15/pr-111475
Aug 9, 2024
Merged

[8.15] ESQL: Fix for overzealous validation in case of invalid mapped fields (#111475)#111735
elasticsearchmachine merged 1 commit intoelastic:8.15from
alex-spies:backport/8.15/pr-111475

Conversation

@alex-spies
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

…elastic#111475)

Fix validation of fields mapped to different types in different indices and align with validation of fields of unsupported type.

* Allow using multi-typed fields in KEEP and DROP, just like unsupported fields.
* Explicitly invalidate using both these field kinds in RENAME.
* Map both kinds of fields to UnsupportedAttribute to enforce consistency.
* Consider convert functions containing valid multi-typed fields as resolved to avoid weird workarounds when resolving STATS.
* Add a bunch of tests.

(cherry picked from commit 585480f)

# Conflicts:
#	x-pack/plugin/esql/qa/testFixtures/src/main/resources/union_types.csv-spec
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Analyzer.java
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/Stats.java
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 9, 2024

Documentation preview:

@alex-spies alex-spies added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Aug 9, 2024
@elasticsearchmachine elasticsearchmachine merged commit e091e16 into elastic:8.15 Aug 9, 2024
@alex-spies alex-spies deleted the backport/8.15/pr-111475 branch August 9, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v8.15.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants