Refactors SpanTermQueryBuilder.#11005
Refactors SpanTermQueryBuilder.#11005MaineC merged 2 commits intoelastic:feature/query-refactoringfrom
Conversation
There was a problem hiding this comment.
Not sure, but if we use parserName() instead of the constant here, can we move the whole doXContent method do the BaseTermQueryBuilder?
e20b6b4 to
24d7ae5
Compare
There was a problem hiding this comment.
I think those two can stay private, or do you need them in the concrete test classes? They should also be accesible via the context you get from createContext() if you need them.
There was a problem hiding this comment.
This must have been a merge artifact - will revert, thanks for spotting this.
|
@cbuescher Thanks for your comments - changed the code accordingly. |
|
Thanks, LGTM, but lets see if anybody else has an opinion. |
There was a problem hiding this comment.
this makes sense, wonder if the comment is even needed, seems more like a commit message ;)
|
left some comments |
8908571 to
da2eb5a
Compare
Refactors SpanTermQueryBuilder analogous to TermQueryBuilder. Factors common code between the two into separate classes.
Relates to #10217
This goes against the feature/query-refactoring branch.