Enable fallback synthetic source by default#109370
Merged
lkts merged 7 commits intoelastic:mainfrom Jun 7, 2024
Merged
Conversation
Collaborator
|
Hi @lkts, I've created a changelog YAML for you. |
f26a615 to
6a4e4cf
Compare
Contributor
Author
|
@elasticmachine update branch |
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
approved these changes
Jun 6, 2024
Member
kkrik-es
left a comment
There was a problem hiding this comment.
Let's test-full-bwc to play it safe.
kkrik-es
reviewed
Jun 6, 2024
| /** | ||
| * Specifies the mode of synthetic source support by the mapper. | ||
| * Field mappers must override this method if they provide | ||
| * a custom implementation of {@link #syntheticFieldLoader()} |
Member
There was a problem hiding this comment.
Consider adding a note there hinting why they should do so.
47555fd to
22d1600
Compare
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables fallback synthetic source as a default for all fields that don't implement synthetic source support. It also adds basic tests for fields that now support synthetic source with that above change.
Closes #106460.