Enable fallback synthetic source for point and shape#109312
Merged
lkts merged 5 commits intoelastic:mainfrom Jun 4, 2024
Merged
Enable fallback synthetic source for point and shape#109312lkts merged 5 commits intoelastic:mainfrom
point and shape#109312lkts merged 5 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
20 tasks
Collaborator
|
Hi @lkts, I've created a changelog YAML for you. |
kkrik-es
reviewed
Jun 4, 2024
| .toList(); | ||
| Object outBlock = outBlockList.size() == 1 ? outBlockList.get(0) : outBlockList; | ||
| return new SyntheticSourceExample(representations, representations, outBlock, this::mapping); | ||
| } else { |
kkrik-es
reviewed
Jun 4, 2024
| .filter(Objects::nonNull) | ||
| .map(CartesianPoint::toWKT) | ||
| .toList(); | ||
| Object outBlock = outBlockList.size() == 1 ? outBlockList.get(0) : outBlockList; |
Member
There was a problem hiding this comment.
Can the list be empty, e.g. if all values are null?
Contributor
Author
There was a problem hiding this comment.
Yes but it is handled in test code separately.
kkrik-es
approved these changes
Jun 4, 2024
Contributor
Author
|
@elasticmachine run elasticsearch-ci/7.17.22 / bwc-snapshots |
Contributor
Author
|
buildkite test this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables fallback synthetic source for
pointandshapefields and adds appropriate tests.Contributes to #106460.