Rename to ChunkedRestResponseBodyPart#109057
Merged
elasticsearchmachine merged 4 commits intoelastic:mainfrom May 27, 2024
Merged
Rename to ChunkedRestResponseBodyPart#109057elasticsearchmachine merged 4 commits intoelastic:mainfrom
ChunkedRestResponseBodyPart#109057elasticsearchmachine merged 4 commits intoelastic:mainfrom
Conversation
Follow-up to elastic#104851 to rename some symbols to reflect that the class formerly known as a `ChunkedRestResponseBody` may now only be _part_ of the whole response body.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
commented
May 27, 2024
Member
Author
DaveCTurner
left a comment
There was a problem hiding this comment.
Apart from rewording some of the javadocs a little and the two added assertions (noted below) this was all mechanical.
| while (firstBodyPart.isPartComplete() == false) { | ||
| refsGenerated.add(firstBodyPart.encodeChunk(randomIntBetween(2, 10), BytesRefRecycler.NON_RECYCLING_INSTANCE)); | ||
| } | ||
| assertTrue(firstBodyPart.isLastPart()); |
Member
Author
There was a problem hiding this comment.
Added this assertion
| while (firstBodyPart.isPartComplete() == false) { | ||
| refsGenerated.add(firstBodyPart.encodeChunk(randomIntBetween(2, 10), BytesRefRecycler.NON_RECYCLING_INSTANCE)); | ||
| } | ||
| assertTrue(firstBodyPart.isLastPart()); |
Member
Author
There was a problem hiding this comment.
Added this assertion
henningandersen
approved these changes
May 27, 2024
server/src/test/java/org/elasticsearch/http/DefaultRestChannelTests.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #104851 to rename some symbols to reflect that the class
formerly known as a
ChunkedRestResponseBodymay now only be part ofthe whole response body.