Enable fallback synthetic source for token_count#109044
Conversation
|
Documentation preview: |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Hi @lkts, I've created a changelog YAML for you. |
|
|
||
| @Override | ||
| public BlockLoader blockLoader(BlockLoaderContext blContext) { | ||
| return null; |
There was a problem hiding this comment.
token_count is not supported in ESQL but TokenCountFieldType inherits blockLoader implementation from NumberFieldType which leads to fun test failures. IMO it is more logical to do this until it is actually supported.
There was a problem hiding this comment.
Okay, that was not a good idea it seems.
There was a problem hiding this comment.
Tests are okay, i was just confused.
martijnvg
left a comment
There was a problem hiding this comment.
LGTM - Typically token_count field type is configured as a multi-field, so it isn't used as part of synthetic source. This change makes it possible to synthesize source in the case a token_count field is configured a main field.
|
@elasticmachine run elasticsearch-ci/part-4 |
|
@elasticmachine update branch |
Enable fallback synthetic source for token_count and add tests.