Fix ESRestTestCase.clusterHasCapability to work in bwc / mixed cluster tests#108889
Merged
mosche merged 2 commits intoelastic:mainfrom May 22, 2024
Merged
Conversation
…r tests when capabilities API is unsupported
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
approved these changes
May 22, 2024
DaveCTurner
reviewed
May 22, 2024
| return Optional.ofNullable((Boolean) response.get("supported")); | ||
| try { | ||
| Map<String, Object> response = entityAsMap(client.performRequest(request).getEntity()); | ||
| return Optional.ofNullable((Boolean) response.get("supported")); |
Member
There was a problem hiding this comment.
Hmm if we get null here that means that some node failed to respond. That seems like it should be a test failure? I.e. can we assert that this isn't null?
Contributor
Author
There was a problem hiding this comment.
Wondering, @thecoop, wouldn't it be more consistent if the API returned a server error in this case?
Contributor
Author
There was a problem hiding this comment.
I'll keep this as is for now. We're going to discuss this independently as a follow up item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ESRestTestCase.clusterHasCapability to work in bwc / mixed cluster tests when capabilities API is unsupported.