Skip to content

Support arrays in fallback synthetic source implementation#108878

Merged
lkts merged 4 commits intoelastic:mainfrom
lkts:feature/synthetic_source_fallback_arrays
May 23, 2024
Merged

Support arrays in fallback synthetic source implementation#108878
lkts merged 4 commits intoelastic:mainfrom
lkts:feature/synthetic_source_fallback_arrays

Conversation

@lkts
Copy link
Copy Markdown
Contributor

@lkts lkts commented May 21, 2024

This PR extends #108222 adding support for arrays.

@lkts lkts added the :StorageEngine/Mapping The storage related side of mappings label May 21, 2024
@lkts lkts requested review from kkrik-es and martijnvg May 21, 2024 18:38
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Hi @lkts, I've created a changelog YAML for you.

Copy link
Copy Markdown
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

&& context.getClonedSource() == false) {
boolean needToStoreObjectArraySource = mapper instanceof ObjectMapper objectMapper
&& objectMapper.storeArraySource()
&& context.getClonedSource() == false;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This applies to both.

@lkts lkts merged commit 1ec137d into elastic:main May 23, 2024
@lkts lkts deleted the feature/synthetic_source_fallback_arrays branch May 23, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants