Merged
Conversation
Contributor
|
Documentation preview: |
docs/reference/cat/nodes.asciidoc
Outdated
Member
There was a problem hiding this comment.
I think the docs refactoring could belong to a separate PR, labeled with "docs", so it's easier to review
Member
Author
There was a problem hiding this comment.
Leaving this here for now as it's consistent with other PRs, apologies for the whitespace formatting. If you feel strongly about it I can create 2 PRs.
server/src/main/java/org/elasticsearch/index/shard/IndexShard.java
Outdated
Show resolved
Hide resolved
...ava/org/elasticsearch/xpack/monitoring/collector/cluster/ClusterStatsMonitoringDocTests.java
Outdated
Show resolved
Hide resolved
eadbf60 to
254a1d6
Compare
kderusso
commented
May 29, 2024
1158acc to
eff9791
Compare
4c244dd to
65374ff
Compare
Member
Author
|
Note: This models after some of the dense vector changes in #107962 |
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Collaborator
|
Hi @kderusso, I've created a changelog YAML for you. |
jimczi
approved these changes
Jun 17, 2024
server/src/main/java/org/elasticsearch/index/engine/Engine.java
Outdated
Show resolved
Hide resolved
ioanatia
reviewed
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #98275
Adds statistics on the number of
sparse_vectorfields in an index or cluster.Because we can't pull dimensionality from the Lucene index, this relies on
sparse_vectormappings to identify the documents to calculate fields for.Here is an example script to test: