Skip to content

Render non-elasticsearch exception as root cause#10850

Merged
s1monw merged 1 commit intoelastic:masterfrom
s1monw:issues/10836
Apr 28, 2015
Merged

Render non-elasticsearch exception as root cause#10850
s1monw merged 1 commit intoelastic:masterfrom
s1monw:issues/10836

Conversation

@s1monw
Copy link
Copy Markdown
Contributor

@s1monw s1monw commented Apr 28, 2015

if we don't have an ElasticsearchException as the wrapper of the
actual cause we don't render a root cause today. This commit adds
support for 3rd party exceptions as root causes.

Closes #10836

@s1monw s1monw added the review label Apr 28, 2015
@jpountz
Copy link
Copy Markdown
Contributor

jpountz commented Apr 28, 2015

LGTM

if we don't have an ElasticsearchException as the wrapper of the
actual cause we don't render a root cause today. This commit adds
support for 3rd party exceptions as root causes.

Closes elastic#10836
@s1monw s1monw merged commit 87cf145 into elastic:master Apr 28, 2015
@s1monw s1monw removed the review label Apr 28, 2015
@spalger
Copy link
Copy Markdown
Contributor

spalger commented Apr 28, 2015

LGTM too

@s1monw
Copy link
Copy Markdown
Contributor Author

s1monw commented Apr 28, 2015

w00t thanks @spalger

@s1monw s1monw deleted the issues/10836 branch April 28, 2015 16:14
@clintongormley clintongormley changed the title [REST] Render non-elasticsearch exception as root cause Render non-elasticsearch exception as root cause Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Core/Infra/REST API REST infrastructure and utilities v2.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Response error.root_cause shouldn't empty

4 participants