ESQL: Disable quoting in FROM command (#108431)#108443
Merged
elasticsearchmachine merged 1 commit intoelastic:8.14from May 9, 2024
Merged
ESQL: Disable quoting in FROM command (#108431)#108443elasticsearchmachine merged 1 commit intoelastic:8.14from
elasticsearchmachine merged 1 commit intoelastic:8.14from
Conversation
Disable location quoting in FROM command before 8.14 release to allow more time to discuss options (cherry picked from commit e56ed71)
jpountz
reviewed
May 13, 2024
| assertIdentifierAsIndexPattern("foo", "from `foo`"); | ||
| assertIdentifierAsIndexPattern("foo,test-*", "from `foo`,`test-*`"); | ||
| // assertIdentifierAsIndexPattern("foo", "from `foo`"); | ||
| // assertIdentifierAsIndexPattern("foo,test-*", "from `foo`,`test-*`"); |
Contributor
There was a problem hiding this comment.
It's a bit awkward to have assertions that are commented out, is this a leftover?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable location quoting in FROM command before 8.14 release to allow
more time to discuss options
(cherry picked from commit e56ed71)
Backport #108431