Skip to content

Unmute SnapshotStatusApisIT#testInfiniteTimeout#108178

Merged
arteam merged 1 commit intomainfrom
unmute-snapshot-status-apis-infinite-timeout
May 3, 2024
Merged

Unmute SnapshotStatusApisIT#testInfiniteTimeout#108178
arteam merged 1 commit intomainfrom
unmute-snapshot-status-apis-infinite-timeout

Conversation

@arteam
Copy link
Copy Markdown
Contributor

@arteam arteam commented May 2, 2024 •
edited
Loading

This test doesn't fail anymore, I've run it 1000 times locally.

This test got introduced in #107050, and I believe the test got fixed in #107675. Unfortunately, the got muted before #107675 got merged, so I can't confirm that PR actually fixed the test on CI.

@arteam
Unmute SnapshotStatusApisIT#testInfiniteTimeout
0d1c2c2 
This test doesn't fail anymore, I've run it 1000 times locally. This test
got introduced in #107050, and I believe the test got fixed in #107675.
Unfortunately, the got muted before #107675 got merged, so I can't confirm
that #107675 fixed the test on CI.
@arteam arteam added >test Issues or PRs that are addressing/adding tests :Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. labels May 2, 2024
@elasticsearchmachine elasticsearchmachine added v8.15.0 Team:Distributed Meta label for distributed team. labels May 2, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented May 2, 2024

Pinging @elastic/es-distributed (Team:Distributed)

ywangd
ywangd approved these changes May 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Did #107675 fix it? Should it resolve #107405?

@arteam arteam merged commit 63294e7 into main May 3, 2024
@arteam arteam deleted the unmute-snapshot-status-apis-infinite-timeout branch May 3, 2024 08:45
@arteam
Copy link
Copy Markdown
Contributor Author

arteam commented May 3, 2024

Thank you! Yes, I believe #107675 fixed the test. I've run it locally 1000 times without failures. Let's run this test on CI and it keeps failing, I will re-open #107405.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywangd ywangd ywangd approved these changes

Assignees

No one assigned

Labels

:Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. Team:Distributed Meta label for distributed team. >test Issues or PRs that are addressing/adding tests v8.15.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arteam @elasticsearchmachine @ywangd