ESQL: Add more tests for constant aggregations#107888
Merged
alex-spies merged 2 commits intoelastic:mainfrom Apr 29, 2024
Merged
ESQL: Add more tests for constant aggregations#107888alex-spies merged 2 commits intoelastic:mainfrom
alex-spies merged 2 commits intoelastic:mainfrom
Conversation
Add cases of foldable expressions to the existing csv tests for each aggregation that supports constants: one that folds to a number, and one that folds to null.
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Contributor
Author
|
Thanks @luigidellaquila ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cases of foldable expressions to the existing csv tests for each
aggregation that supports constants: one that folds to a number, and one
that folds to null.