Binary field enables doc values by default for index mode with synthetic source#107739
Merged
lkts merged 2 commits intoelastic:mainfrom Apr 23, 2024
Merged
Binary field enables doc values by default for index mode with synthetic source#107739lkts merged 2 commits intoelastic:mainfrom
lkts merged 2 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @lkts, I've created a changelog YAML for you. |
martijnvg
approved these changes
Apr 23, 2024
Member
martijnvg
left a comment
There was a problem hiding this comment.
Left one testing comment, LGTM otherwise.
|
|
||
| List<IndexableField> fields = doc.rootDoc().getFields("field"); | ||
| var docValuesField = fields.stream().filter(f -> f.fieldType().docValuesType() == DocValuesType.BINARY).findFirst(); | ||
| assertTrue("Doc values are not present", docValuesField.isPresent()); |
Member
There was a problem hiding this comment.
Maybe also assert in this test that doc values field isn't present if non tsdb index settings are used?
Contributor
Author
There was a problem hiding this comment.
We test this in another test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107554.