[8.13] ESQL: Introduce language versioning to REST API (#106824)#107301
Merged
alex-spies merged 1 commit intoelastic:8.13from Apr 10, 2024
Merged
[8.13] ESQL: Introduce language versioning to REST API (#106824)#107301alex-spies merged 1 commit intoelastic:8.13from
alex-spies merged 1 commit intoelastic:8.13from
Conversation
For the _query endpoint, add a parameter for the ESQL language version to the JSON payload. For now, it is optional and is only validated with no further action. (cherry picked from commit 147f5a0) # Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/esql/action/EsqlQueryRequest.java # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/esql/action/EsqlQueryRequestBuilder.java # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlQueryRequest.java # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlQueryRequestBuilder.java # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/RequestXContent.java
nik9000
approved these changes
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will backport the following commits from
mainto8.13:This will allow sending the ES|QL version in REST requests but will do nothing with the
versionparameter; sendingversionis also not enforced.This is required to allow sending
versionin clusters of mixed ES versions (i.e. 8.14 and 8.13); without this, our bwc tests fail when we make our integration tests send theversion(like #107268 for example).