ESQL: Better tests to AUTO_BUCKET#107228
Merged
elasticsearchmachine merged 3 commits intoelastic:mainfrom Apr 9, 2024
Merged
Conversation
This improves the tests for AUTO_BUCKET marginally, specifically so that it tests all valid combinations of arguments and generates a correct types table. This'll combine nicely with elastic#106782 to generate the signatures that kibana needs for it's editor.
Contributor
|
Documentation preview: |
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
commented
Apr 8, 2024
| // TODO check for a limit 4. is arbitrary. | ||
| throw new IllegalArgumentException("would generate too many types"); | ||
| if (argumentCount > 3) { | ||
| throw new IllegalArgumentException("would generate too many combinations"); |
Member
Author
There was a problem hiding this comment.
4 is like 80k test cases. Too many I think.
bpintea
reviewed
Apr 9, 2024
|
|
||
| private static Matcher<Object> numericResultsMatcher(List<TestCaseSupplier.TypedData> typedData, Object value) { | ||
| return equalTo(value); | ||
| private static TestCaseSupplier.TypedData keywordDateLiteral(String name, DataType type, String date) { |
fang-xing-esql
approved these changes
Apr 9, 2024
Member
fang-xing-esql
left a comment
There was a problem hiding this comment.
LGTM! Except LocateNoStartEvaluator is not relevant.
Member
Author
There was a problem hiding this comment.
It's something we should have committed before. I figured I'd just land it with whatever PR. It looks like Alex landed it all on it's own though. So it's gone from this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the tests for AUTO_BUCKET marginally, specifically so that it tests all valid combinations of arguments and generates a correct types table. This'll combine nicely with #106782 to generate the signatures that kibana needs for it's editor.