Skip to content

ESQL: Add version to docs#107225

Merged
elasticsearchmachine merged 6 commits intoelastic:mainfrom
alex-spies:esql-version-docs
Apr 15, 2024
Merged

ESQL: Add version to docs#107225
elasticsearchmachine merged 6 commits intoelastic:mainfrom
alex-spies:esql-version-docs

Conversation

@alex-spies
Copy link
Copy Markdown
Contributor

@alex-spies alex-spies commented Apr 8, 2024

Docs for #106824.

Does not cover the REST API specs as these don't cover the request body.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2024

Documentation preview:

@alex-spies alex-spies marked this pull request as ready for review April 11, 2024 14:55
@alex-spies alex-spies added >docs General docs changes :Analytics/ES|QL AKA ESQL labels Apr 11, 2024
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Apr 11, 2024
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Copy Markdown
Member

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little copyediting from me :)

Their goal is to make sure that queries that were once written
remain valid even as Elasticsearch and {esql} evolve.

For instance, the following query
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't read well to have a code sample mid-sentence, so I'd recommend moving lines 41 + 42 up here.

nik9000 and others added 3 commits April 15, 2024 10:20
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
@nik9000 nik9000 added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Apr 15, 2024
@elasticsearchmachine elasticsearchmachine merged commit 71b276d into elastic:main Apr 15, 2024
@alex-spies alex-spies deleted the esql-version-docs branch April 15, 2024 14:50
@alex-spies
Copy link
Copy Markdown
Contributor Author

Thanks for your help @nik9000 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v8.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants