Fix ES|QL locate with supplementary (4-byte) character#107172
Merged
ChrisHegarty merged 13 commits intoelastic:mainfrom Apr 8, 2024
Merged
Fix ES|QL locate with supplementary (4-byte) character#107172ChrisHegarty merged 13 commits intoelastic:mainfrom
ChrisHegarty merged 13 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
ChrisHegarty
commented
Apr 5, 2024
...sql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/string/Locate.java
Show resolved
Hide resolved
ChrisHegarty
commented
Apr 5, 2024
| assertThat(process("界世", "界世", 0), equalTo(1)); | ||
| } | ||
|
|
||
| public void testSupplementaryCharacter() { |
Contributor
Author
There was a problem hiding this comment.
I put all these tests in one place, because supplementary chars hurt ones head - it's easier to reason about them when they're all together.
Member
There was a problem hiding this comment.
After this is in I can see about breaking these in the the parameterize stuff.
ChrisHegarty
commented
Apr 6, 2024
.../src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/string/Substring.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
ChrisHegarty
commented
Apr 6, 2024
x-pack/plugin/esql/qa/testFixtures/src/main/resources/string.csv-spec
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
tteofili
approved these changes
Apr 8, 2024
Contributor
tteofili
left a comment
There was a problem hiding this comment.
thanks @ChrisHegarty for this, LGTM
nik9000
approved these changes
Apr 8, 2024
| assertThat(process("界世", "界世", 0), equalTo(1)); | ||
| } | ||
|
|
||
| public void testSupplementaryCharacter() { |
Member
There was a problem hiding this comment.
After this is in I can see about breaking these in the the parameterize stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the ES|QL locate with supplementary (4-byte) character.